root/trunk/batman-adv-kernelland/vis.h @ 1579

Revision 1579, 1.9 kB (checked in by marek, 6 months ago)

batman-adv: don't have interrupts disabled while sending.

send_vis_packets() would disable interrupts before calling
dev_queue_xmit() which resulting in a backtrace in local_bh_enable().
Fix this by using kref on the vis_info object so that we can call
send_vis_packets() without holding vis_hash_lock. vis_hash_lock also
used to protect recv_list, so we now need a new lock to protect that
instead of vis_hash_lock.

Also a few checkpatch cleanups.

Reported-by: Linus Luessing <linus.luessing@…>
Signed-off-by: Andrew Lunn <andrew@…>
Signed-off-by: Marek Lindner <lindner_marek@…>
Signed-off-by: Simon Wunderlich <siwu@…>

Line 
1/*
2 * Copyright (C) 2008-2009 B.A.T.M.A.N. contributors:
3 *
4 * Simon Wunderlich, Marek Lindner
5 *
6 * This program is free software; you can redistribute it and/or
7 * modify it under the terms of version 2 of the GNU General Public
8 * License as published by the Free Software Foundation.
9 *
10 * This program is distributed in the hope that it will be useful, but
11 * WITHOUT ANY WARRANTY; without even the implied warranty of
12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
13 * General Public License for more details.
14 *
15 * You should have received a copy of the GNU General Public License
16 * along with this program; if not, write to the Free Software
17 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
18 * 02110-1301, USA
19 *
20 */
21
22#define VIS_TIMEOUT             200000
23#define VIS_FORMAT_DD_NAME      "dot_draw"
24#define VIS_FORMAT_JSON_NAME    "json"
25
26struct vis_info {
27        unsigned long       first_seen;
28        struct list_head    recv_list;
29                            /* list of server-neighbors we received a vis-packet
30                             * from.  we should not reply to them. */
31        struct list_head send_list;
32        struct kref refcount;
33        /* this packet might be part of the vis send queue. */
34        struct vis_packet packet;
35        /* vis_info may follow here*/
36} __attribute__((packed));
37
38struct vis_info_entry {
39        uint8_t  src[ETH_ALEN];
40        uint8_t  dest[ETH_ALEN];
41        uint8_t  quality;       /* quality = 0 means HNA */
42} __attribute__((packed));
43
44struct recvlist_node {
45        struct list_head list;
46        uint8_t mac[ETH_ALEN];
47};
48
49extern struct hashtable_t *vis_hash;
50extern spinlock_t vis_hash_lock;
51
52void proc_vis_read_entry(struct seq_file *seq,
53                                struct vis_info_entry *entry,
54                                struct hlist_head *if_list,
55                                uint8_t *vis_orig);
56void proc_vis_read_prim_sec(struct seq_file *seq,
57                            struct hlist_head *if_list);
58void receive_server_sync_packet(struct vis_packet *vis_packet,
59                                int vis_info_len);
60void receive_client_update_packet(struct vis_packet *vis_packet,
61                                  int vis_info_len);
62int vis_init(void);
63void vis_quit(void);
Note: See TracBrowser for help on using the browser.